Wireshark-bugs: [Wireshark-bugs] [Bug 2974] New: packet-radius.c - avp specific dissectors broke
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 17 Oct 2008 04:42:00 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2974

           Summary: packet-radius.c - avp specific dissectors broken
           Product: Wireshark
           Version: SVN
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: flo@xxxxxxxxxx


Build Information:
Version 1.1.2 (SVN Rev 26485)

Copyright 1998-2008 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.12.8, with GLib 2.16.2, with libpcap 0.9.8, with libz
1.2.3.3, with POSIX capabilities (Linux), with libpcre 7.6, without SMI,
without
c-ares, with ADNS, without Lua, with GnuTLS 2.4.1, with Gcrypt 1.4.0, with MIT
Kerberos, with PortAudio V19-devel (built Oct 25 2007), without AirPcap.

Running on Linux 2.6.24-rc8, with libpcap version 0.9.8.

Built using gcc 4.2.2 (Debian 4.2.2-1).

--

Hi,

the radius avp specific dissectors registered with
radius_register_avp_dissector are broken. The problem is that they are
registered before the dictionary loads. The loading of the dictionary then
replaces the previously added avps in the g_hash_table. 

This functionality is used by packet-gtp.c, packet-radius_packetcable.c and
from what i found it packet-radius.c itself.

I have used the following patch to solve this (as i am implementing a
ascend-data-filter specific dissector right now).

I am unshure this is the right way as the order of init is not fixed as i
understand it. Probably fixing dictionary loading to not overwrite the full avp
but rather copying the dissector over would be more robust.

Flo


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.