Wireshark-bugs: [Wireshark-bugs] [Bug 2960] Update packet-redbackli.c to cover the newest avps
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 13 Oct 2008 10:38:18 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2960





--- Comment #5 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-10-13 10:38:17 PDT ---
No, no, no, this is not the way to do it. Use proto_tree_add_item() as much as
possible and define the header fields properly. That takes care of retrieving
the data from the TVB, so don't do it yourself. It only adds clutter to the
code.

As is promoting redbackli_handle to module level. For what? You don't need it
outside proto_reg_handoff_redbackli() so don't pollute the module namespace. 
Same for including epan/prefs.h. Don't do that when you don't define
preferences.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.