Wireshark-bugs: [Wireshark-bugs] [Bug 2798] New Dissector: IEEE C37.118 Synchrophasor Protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 6 Oct 2008 10:06:56 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2798





--- Comment #10 from Bill Meier <wmeier@xxxxxxxxxxx>  2008-10-06 10:06:55 PDT ---
A few additional quite minor comments:

1. In proto_register... the 'if (proto_synphasor == -1) {' is not required
since proto_register.... is called only once during Wireshark startup.

2. In proto_reg_handoff... the '... int current...' should be '... guint ...'
to match the global versions of same.

3. In Makefile.common  I would guess that the packet-synphasor... files no
longer need to be in the DIRTY_DISSECTOR_SRC section since the issue with the
warnings has been fixed....


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.