https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2935
--- Comment #5 from Bill Meier <wmeier@xxxxxxxxxxx> 2008-10-04 06:48:19 PDT ---
Some additional comments:
1. Please add the following just before the "This program ..."
(You may also add your own copyright notice if desired;
See any of the other dissectors for an example).
*
* $Id$
*
* Wireshark - Network traffic analyzer
* By Gerald Combs <gerald@xxxxxxxxxxxxx>
* Copyright 1998 Gerald Combs
*
2. It doesn't appear that #include <emem.h> is needed.
3. The code in dissect_simulcrypt_message (starting at about line 684)
looks like the indentation needs some clean-up.
4. The variable data_handle is not used.
5. is a separate .h file needed ??
6. proto_reg_handoff ....
I don't understand the purpose of the following:
datagram_handle=find_dissector(tab_ecm_inter[i].protocol_name);
dissector_delete("tcp.port", tcp_port, datagram_handle);
As far as I can see packet-simulcrypt never does a dissector_add(...)
on "tcp.port" for ...protocol_name so therefore a dissector_delete(..)
shouldn't be required.
Could you explain ?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
