Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 2831] Add support the KDP (Kontiki Delivery Protocol)

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2831





--- Comment #4 from Guy Harris <guy@xxxxxxxxxxxx>  2008-08-27 18:45:49 PDT ---
> Thanks for the comments. I've fixed points 1-3 and 5-7, but I'm not clear how
> you want me to fix point 4. I assume you're referring to this bit of code:
> 
> if (check_col(pinfo->cinfo, COL_PROTOCOL)) {
>       col_set_str(pinfo->cinfo, COL_PROTOCOL, "KDP");
> }

Yes.

> I took this from README.developer,

You took those lines of code from README.developer, but you didn't take the
surrounding code from there.  In README.developer, those lines of code are not
inside

    if (tree) {

        ...

    }

> and I noticed that lots of other plugins do this too.

Yes, but do they do it *inside "if (tree)"?  If so, they're buggy, too.

> Can you give me some more details about how you'd like this changed?

Move those lines of code *before* the

    if (tree) {

in dissect_kdp().

Also, don't do anything to COL_INFO inside

    if (tree) {

        ...

    }

Call col_clear(pinfo->cinfo, COL_INFO) before the first "if (tree) {", and do
the updates of COL_INFO outside "if (tree) {".


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.