Wireshark-bugs: [Wireshark-bugs] [Bug 2825] Patch: expanded dissection of the kademlia protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 22 Aug 2008 11:17:31 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2825





--- Comment #2 from LEGO <luis.ontanon@xxxxxxxxx>  2008-08-22 11:17:30 PDT ---
(From update of attachment 2176)
here's something wrong... we are dereferencing a pointer in one line and
testing for it in the following line.

Either for good, it cannot be NULL and so the test in the following line is
useless, or for bad it can actually be NULL and crash when derreferenced.


@@ -863,8 +921,8 @@

     tag_full_name = "UnknownTagName";

+    tagname_value = *(guint8*)tagname;
     if ( tagname && string_length == 1 ) {
-        guint8 tagname_value = *(guint8*)tagname;
         /* lookup tagname */
         tag_full_name = val_to_str( tagname_value, kademlia_tags,
tag_full_name );
     }


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.