Wireshark-bugs: [Wireshark-bugs] [Bug 2798] New Dissector: IEEE C37.118 Synchrophasor Protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 12 Aug 2008 08:00:57 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2798





--- Comment #5 from LEGO <luis.ontanon@xxxxxxxxx>  2008-08-12 08:00:17 PDT ---
(In reply to comment #3)
> > - The inline keyword does not fly with regular C compilers. 
> fixed, good compiler should inline anyway.

Gcc inlines all static functions that are refered only once... I do not know
about other functions.

> > Furthermore it should be possible to make it compile cleanly. Could you
> > elaborate on the comment
> > # this plugin won't compile w/o warnings because
> > # of unused parameters in the callbacks
> the 'get_pdu_length()' callback doesn't need all parameters, and that causes an
> error. Does WS have macros to add something like gccs '__attribute__((unused))'
> for various compilers? Omitting the parameter name is only valid in c++, IIRC.

We use the _U_ macro for unused parameters

as in foo(... ,type* arg _U_, ...)


BR


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.