Wireshark-bugs: [Wireshark-bugs] [Bug 2774] New: add inband credit grant decode to packet-pppoe.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 5 Aug 2008 13:15:37 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2774

           Summary: add inband credit grant decode to packet-pppoe.c
           Product: Wireshark
           Version: SVN
          Platform: PC
        OS/Version: All
            Status: ASSIGNED
          Severity: Minor
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: pdice@xxxxxxxxx



Edward J. Paradise <pdice@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2115|                            |review_for_checkin?
               Flag|                            |


Created an attachment (id=2115)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2115)
proposed_patch

Build Information:
Version 1.0.99 (SVN Rev 25876)

Copyright 1998-2008 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.10.11, with GLib 2.12.11, with libpcap 0.9.8, with libz
1.2.3, with POSIX capabilities (Linux), with libpcre 7.0, without SMI, without
ADNS, without Lua, with GnuTLS 1.4.5, with Gcrypt 1.2.4, with MIT Kerberos,
without PortAudio, without AirPcap.

Running on Linux 2.6.21-1.3194.fc7, with libpcap version 0.9.8.

Built using gcc 4.1.2 20070502 (Red Hat 4.1.2-12).

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
rfc4938 defines two credit granting mechanisms, out-of-band and inband.  The
current decoding mechanism in packet-pppoe.c only decodes out-of-band credit
grants.  This patches addresses decoding of inband credit as well.  In
addition, I added filters for these tags in the pppoes packets.  Previously,
the common pppoe filters were under the pppoed filter registration, but now
since there are pppoed and pppoes filters, I moved them out on their own.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.