Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 2752] Add Ethernet Global Data dissector

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2752





--- Comment #6 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-07-30 15:13:33 PDT ---
Oke, looking much better already. Still a few points.

You're never initialized, even when you are...

Creating hidden items get you scorned by some of the developers. I understand
you want to filter on these items, so just add these first, then add human
readable item. You could even mark that as generated, although it's not.

The thing with protocol analyzers is that they tend to expose every bit of the
protocols, even (or should I say especially) when they are application
specific. Handing the data to the data dissector makes it possible for the user
to look at (the first part of) the data without begin forced to open the packet
bytes pane. That could just be enough for the power user, whose needs we try to
address.

Your dissector should be added to the CLEAN_DISSECTOR_SRC symbol, not the dirty
list. Sort it, so stick it in between packet-edonkey.c and packet-eigrp.c and
make sure it compiles.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.