Wireshark-bugs: [Wireshark-bugs] [Bug 2548] wimax UL-MAP ext IE decode error
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 23 Jun 2008 02:34:25 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2548





--- Comment #9 from Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>  2008-06-23 02:34:25 PDT ---
OK, I checked your patches in with change 25528.

But please review the state of msg_ulmap.c

CQICH_Alloc_IE (line 1145) has at line 1158:
    ti = proto_tree_add_text(uiuc_tree, tvb, NIBHI(offset, length),
"UL_ZONE_IE");


whereas post your change:


UL_Zone_IE (line 1215) has at line 1227:
    ti = proto_tree_add_text(uiuc_tree, tvb, NIBHI(offset, length),
"CQICH_Alloc_IE");


These look backwards to me - should they be swapped?


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.