Wireshark-bugs: [Wireshark-bugs] [Bug 2556] patch to support WSA, WSMP, WRSS packets
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 20 May 2008 06:20:22 -0700 (PDT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2556





--- Comment #5 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-05-20 06:20:22 PDT ---
Any reason not to make this a build-in dissector? 
The module stuff in packet-wsmp.c shouldn't be there, nor the occasional C++
comments. The documentation comments left in there could be purged as well. 
Why retrieve a string/letoh and then only add them to the tree? Use of
appropriate proto_tree_add_item() gives a better result.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.