Wireshark-bugs: [Wireshark-bugs] [Bug 2466] Add XTP(Xpress Transport Protocol) dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 16 Apr 2008 05:55:07 -0700 (PDT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2466


Stig Bjørlykke <stig@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stig@xxxxxxxxxxxxx




--- Comment #4 from Stig Bjørlykke <stig@xxxxxxxxxxxxx>  2008-04-16 05:55:06 GMT ---
Hi.  After a quick look I have the following comments:

1. Compile with --enable-warnings-as-errors and fix all warnings.  I found at
least one bug while looking at the warnings :)

2. You often allocate a struct with ep_alloc which you only use internal in a
function.  As the structs are not used to anything outside the function I
propose using regular variables instead of allocating memory.

3. You have to add some heuristic checks before starting to handle the package
as xtp.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.