Wireshark-bugs: [Wireshark-bugs] [Bug 2445] register_menu() Lua function has three parameters
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 10 Apr 2008 20:08:30 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2445


LEGO <luis.ontanon@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from LEGO <luis.ontanon@xxxxxxxxx>  2008-04-10 20:08:29 GMT ---
taking a look at the code in line 82 we see

        register_stat_group_t group =
(int)luaL_optnumber(L,WSLUA_ARG_register_menu_GROUP,REGISTER_REGISTER_STAT_GROUP_GENERIC);

that means it is optional and defaults to MENU_STAT_GENERIC

I checked in you patch slightly modified in rev 24879
- changed the def of the group argument to be WSLUA_OPTARG_register_menu_GROUP
so its marked as optional in the generated docs.
- fixed one typo 
    /*  Register a menu item in the one of the main menus. */
 vs /*  Register a menu item in one of the main menus. */
- changed (function) with (function taking no arguments and returning nothing)

Thanks!


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.