Wireshark-bugs: [Wireshark-bugs] [Bug 1723] Enhancement of text2cap for parsing flexibility
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 21 Jan 2008 01:29:05 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1723





--- Comment #7 from Richard van der Hoff <richardv@xxxxxxxxxxxxx>  2008-01-21 01:29:02 GMT ---
Sorry for taking so long to look at this again.

I still have some questions, and comments:

 * Why do we need to add extra options for this functionality? It certainly
sounds like you would never want to run without the -A option, and I think you
could argue the same for the -D option.  It seems pointless to keep adding more
and more options that nobody would ever want disabled. 

 * Why do you think we will want a comment in the finished article saying "This
modification is for supporting: ..." ?  That's only meaningful in the context
of this patch, and will just be confusing for somebody looking at the file in
future.

 * // comments are also not valid c89, please stick to /* */ ones.

 * could the EOL logic go into a separate function, so that you don't need to
add more variables to parse_token (which is already quite long)?

Thanks for your work on this, but it would be nice if you could polish the
patch a little more.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.