Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 2017] VoIP trace crashes Wireshark when specific RTP Player buttons are clicke

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2017


stephentfisher@xxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stephentfisher@xxxxxxxxx




------- Comment #31 from stephentfisher@xxxxxxxxx  2008-01-09 09:30 GMT -------
Jim - Please see the patch I attached to this bug called option #3 and try it
out on your local sources with your debugging code in place.  Make sure you
update to the latest svn tree first or else it won't apply.

The tapping code may run RTP_packet_draw() multiple times as you and I have
seen.  This is normal behavior since it should run once per "hit" on the tap in
the RTP dissector.  It seems to run once or twice depending on which packet I
highlight before going to stats->voip calls (higher than 12 and it hits twice).

I determined that strinfo->pt_str is set when a list entry is first created, so
it should not be destroyed (freed) until the end of the voip stats code.  My
patch places the frees in voip_calls_reset(), which is called from the code in
gtk/voip_calls_dlg.c that runs when the voip stats window is closed.  I also
removed the g_free(strinfo->pt_str) in the loop that sometimes runs too many
times when the tap is run multiple times.  This solves the crash from my
testing so far, but please verify for me that it works for you too.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.