Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 2050] New: Duplicate display filter fields with SVN22825 of packet-bfd.c

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2050

           Summary: Duplicate display filter fields with SVN22825 of packet-
                    bfd.c
           Product: Wireshark
           Version: SVN
          Platform: PC
               URL: http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1787#
                    c5
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: christopher.maynard@xxxxxxxxx


Build Information:
SVN 23671.
--
With Todd J. Martin's (todd.martin@xxxxxxx) change to packet-bfd.c from
SVN18853 to SVN22825, he introduced two duplicate display filter fields when he
changed the PROTOABBREV from bfdcontrol to bfd.

I prefer the new PROTOABBREV of bfd over bfdcontrol, but the following 2
duplicates should be resolved and perhaps other fields should be reviewed as
well to make sure they are still aptly named.  The 2 duplicate fields are:

bfd.flags.p
bfd.flags.f
bfd.flags.d

Also, the descriptions for the p and d fields need to be swapped.

Lastly, since it's very difficult to manually check display filter fields by
hand for correctness, I think it would be very beneficial if someone could come
up with an automated way for checking display filter field syntax and checking
for duplicates.

Reference: 
http://anonsvn.wireshark.org/viewvc/viewvc.py/trunk/epan/dissectors/packet-bfd.c?view=log


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.