Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 1970] review_for_checkin : plugins IPMB protocol with GPL version 2

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1970





------- Comment #5 from gerald@xxxxxxxxxxxxx  2007-11-29 01:02 GMT -------
I tried compiling the patch, but ran into a few errors:

chassis.c: In function 'dissect_cmd_Get_Chassis_Capabilities':
chassis.c:51: warning: unused variable 'chassisFRU'
chassis.c: In function 'dissect_cmd_Get_Chassis_Status':
chassis.c:130: warning: unused parameter 'len'
chassis.c: In function 'dissect_cmd_Get_POH_Counter':
chassis.c:236: warning: unused variable 'tf'
chassis.c:235: warning: unused variable 'field_tree'
chassis.c:232: warning: unused parameter 'len'
chassis.c:233: warning: unused parameter 'auth_offset'
packet-ipmb.c:1112:1: warning: "/*" within comment
packet-ipmb.c:1228: warning: initialization from incompatible pointer type
packet-ipmb.c:1229: warning: initialization from incompatible pointer type
packet-ipmb.c:1238: warning: initialization from incompatible pointer type
packet-ipmb.c:1268: warning: initialization from incompatible pointer type
packet-ipmb.c:1269: warning: initialization from incompatible pointer type
packet-ipmb.c:1270: warning: initialization from incompatible pointer type
packet-ipmb.c:1279: warning: initialization from incompatible pointer type
packet-ipmb.c:1280: warning: initialization from incompatible pointer type
packet-ipmb.c:1281: warning: initialization from incompatible pointer type
packet-ipmb.c:1283: warning: initialization from incompatible pointer type
packet-ipmb.c:1284: warning: initialization from incompatible pointer type
packet-ipmb.c:1285: warning: initialization from incompatible pointer type
packet-ipmb.c:1286: warning: initialization from incompatible pointer type
packet-ipmb.c:1287: warning: initialization from incompatible pointer type
packet-ipmb.c:1288: warning: initialization from incompatible pointer type
packet-ipmb.c:1291: warning: initialization from incompatible pointer type
packet-ipmb.c:1295: warning: initialization from incompatible pointer type
packet-ipmb.c:1298: warning: initialization from incompatible pointer type
packet-ipmb.c:1304: warning: initialization from incompatible pointer type
packet-ipmb.c:1305: warning: initialization from incompatible pointer type
packet-ipmb.c:1306: warning: initialization from incompatible pointer type
packet-ipmb.c:1307: warning: initialization from incompatible pointer type
packet-ipmb.c:1308: warning: initialization from incompatible pointer type
packet-ipmb.c:1309: warning: initialization from incompatible pointer type
packet-ipmb.c:1310: warning: initialization from incompatible pointer type
packet-ipmb.c:1311: warning: initialization from incompatible pointer type
packet-ipmb.c:1312: warning: initialization from incompatible pointer type
packet-ipmb.c:1314: warning: initialization from incompatible pointer type
packet-ipmb.c:1316: warning: initialization from incompatible pointer type
packet-ipmb.c:1333: warning: initialization from incompatible pointer type
packet-ipmb.c:1334: warning: initialization from incompatible pointer type
packet-ipmb.c:1335: warning: initialization from incompatible pointer type
packet-ipmb.c:1350: warning: initialization from incompatible pointer type
packet-ipmb.c:1351: warning: initialization from incompatible pointer type
packet-ipmb.c:1352: warning: initialization from incompatible pointer type
packet-ipmb.c:1353: warning: initialization from incompatible pointer type
packet-ipmb.c:1354: warning: initialization from incompatible pointer type
packet-ipmb.c:1356: warning: initialization from incompatible pointer type
packet-ipmb.c:1357: warning: initialization from incompatible pointer type
packet-ipmb.c:1358: warning: initialization from incompatible pointer type
packet-ipmb.c:1359: warning: initialization from incompatible pointer type
packet-ipmb.c:1363: warning: initialization from incompatible pointer type
packet-ipmb.c:1364: warning: initialization from incompatible pointer type
packet-ipmb.c:1369: warning: initialization from incompatible pointer type
packet-ipmb.c:1370: warning: initialization from incompatible pointer type
packet-ipmb.c:1373: warning: initialization from incompatible pointer type
packet-ipmb.c:1374: warning: initialization from incompatible pointer type
packet-ipmb.c:1375: warning: initialization from incompatible pointer type
packet-ipmb.c:1376: warning: initialization from incompatible pointer type
packet-ipmb.c:1377: warning: initialization from incompatible pointer type
packet-ipmb.c:1378: warning: initialization from incompatible pointer type
packet-ipmb.c:1379: warning: initialization from incompatible pointer type
packet-ipmb.c:1380: warning: initialization from incompatible pointer type
packet-ipmb.c:1381: warning: initialization from incompatible pointer type
packet-ipmb.c:1382: warning: initialization from incompatible pointer type
packet-ipmb.c:1383: warning: initialization from incompatible pointer type
packet-ipmb.c:1384: warning: initialization from incompatible pointer type
packet-ipmb.c:1385: warning: initialization from incompatible pointer type
packet-ipmb.c:1386: warning: initialization from incompatible pointer type
packet-ipmb.c:1387: warning: initialization from incompatible pointer type
packet-ipmb.c:1390: warning: initialization from incompatible pointer type
packet-ipmb.c:1391: warning: initialization from incompatible pointer type
packet-ipmb.c:1393: warning: initialization from incompatible pointer type
packet-ipmb.c:1394: warning: initialization from incompatible pointer type
packet-ipmb.c:1395: warning: initialization from incompatible pointer type
packet-ipmb.c:1396: warning: initialization from incompatible pointer type
packet-ipmb.c:1397: warning: initialization from incompatible pointer type
packet-ipmb.c:1398: warning: initialization from incompatible pointer type
packet-ipmb.c:1399: warning: initialization from incompatible pointer type
packet-ipmb.c:1400: warning: initialization from incompatible pointer type
packet-ipmb.c:1401: warning: initialization from incompatible pointer type
packet-ipmb.c:1402: warning: initialization from incompatible pointer type
packet-ipmb.c:1403: warning: initialization from incompatible pointer type
packet-ipmb.c:1404: warning: initialization from incompatible pointer type
packet-ipmb.c:1405: warning: initialization from incompatible pointer type
packet-ipmb.c:1406: warning: initialization from incompatible pointer type
packet-ipmb.c:1407: warning: initialization from incompatible pointer type
packet-ipmb.c:1408: warning: initialization from incompatible pointer type
packet-ipmb.c:1409: warning: initialization from incompatible pointer type
packet-ipmb.c: In function 'dissect_ipmb':
packet-ipmb.c:1768: warning: ISO C90 forbids mixed declarations and code
packet-ipmb.c:1768: warning: unused variable 'seq'
source='sensorevent.c' object='sensorevent.lo' libtool=yes \
depfile='.deps/sensorevent.Plo' tmpdepfile='.deps/sensorevent.TPlo' \
depmode=gcc3 /bin/sh ../../depcomp \
/bin/sh ../../libtool --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../..
-I../.. -I/tmp/inst/include  -I/opt/local/include -I/opt/local/include
-I/usr/include '-DPLUGIN_DIR="/tmp/inst/lib/wireshark/plugins/0.99.8"'  -DINET6
-no-cpp-precomp -D_U_="__attribute__((unused))" -g -O2 -Wall -W
-Wdeclaration-after-statement -Wendif-labels -Wpointer-arith -Wno-pointer-sign
-DXTHREADS -D_REENTRANT -I/opt/local/include/gtk-2.0
-I/opt/local/lib/gtk-2.0/include -I/opt/local/include/atk-1.0
-I/opt/local/include/cairo -I/opt/local/include/pango-1.0
-I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include
-I/opt/local/include -I/opt/local/include/freetype2
-I/opt/local/include/libpng12 -I/usr/X11R6/include   -I/opt/local/include
-I/opt/local/include -I/usr/include -c -o sensorevent.lo `test -f
'sensorevent.c' || echo './'`sensorevent.c
 gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../.. -I/tmp/inst/include
-I/opt/local/include -I/opt/local/include -I/usr/include
-DPLUGIN_DIR=\"/tmp/inst/lib/wireshark/plugins/0.99.8\" -DINET6 -no-cpp-precomp
"-D_U_=__attribute__((unused))" -g -O2 -Wall -W -Wdeclaration-after-statement
-Wendif-labels -Wpointer-arith -Wno-pointer-sign -DXTHREADS -D_REENTRANT
-I/opt/local/include/gtk-2.0 -I/opt/local/lib/gtk-2.0/include
-I/opt/local/include/atk-1.0 -I/opt/local/include/cairo
-I/opt/local/include/pango-1.0 -I/opt/local/include/glib-2.0
-I/opt/local/lib/glib-2.0/include -I/opt/local/include
-I/opt/local/include/freetype2 -I/opt/local/include/libpng12
-I/usr/X11R6/include -I/opt/local/include -I/opt/local/include -I/usr/include
-c application.c -MT application.lo -MD -MP -MF .deps/application.TPlo 
-fno-common -DPIC -o .libs/application.o
In file included from application.c:34:
packet-ipmb.h:30:15: warning: missing whitespace after the macro name
packet-ipmb.c: In function 'proto_reg_handoff_ipmb':
packet-ipmb.c:6022: error: 'WTAP_ENCAP_IPMB' undeclared (first use in this
function)
packet-ipmb.c:6022: error: (Each undeclared identifier is reported only once
packet-ipmb.c:6022: error: for each function it appears in.)
make[3]: *** [packet-ipmb.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
application.c: In function 'dissect_cmd_Get_Self_Test_Result':
application.c:181: warning: unused parameter 'len'
application.c: In function 'dissect_cmd_Set_Watchdog_Timer':
application.c:268: warning: unused parameter 'len'
application.c: In function 'dissect_cmd_Get_Watchdog_Timer':
application.c:374: warning: unused parameter 'len'
application.c: In function 'dissect_cmd_Set_BMC_Global_Enables':
application.c:481: warning: unused parameter 'len'
application.c: In function 'dissect_cmd_Get_BMC_Global_Enables':
application.c:526: warning: unused parameter 'len'
application.c: In function 'dissect_cmd_Clear_Message_Flags':
application.c:570: warning: unused parameter 'len'
application.c: In function 'dissect_cmd_Get_Message_Flags':
application.c:616: warning: unused parameter 'len'
application.c: In function 'dissect_cmd_Enable_Message_Channel_Receive':
application.c:662: warning: unused parameter 'len'
application.c: In function 'dissect_cmd_Get_BT_Interface_Capabilities':
application.c:1190: warning: unused parameter 'len'
application.c:1191: warning: unused parameter 'auth_offset'
application.c: In function 'dissect_cmd_Get_Channel_Auth_Capabilities':
application.c:1237: warning: unused parameter 'len'
application.c:1237: warning: unused parameter 'auth_offset'
 gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../.. -I/tmp/inst/include
-I/opt/local/include -I/opt/local/include -I/usr/include
-DPLUGIN_DIR=\"/tmp/inst/lib/wireshark/plugins/0.99.8\" -DINET6 -no-cpp-precomp
"-D_U_=__attribute__((unused))" -g -O2 -Wall -W -Wdeclaration-after-statement
-Wendif-labels -Wpointer-arith -Wno-pointer-sign -DXTHREADS -D_REENTRANT
-I/opt/local/include/gtk-2.0 -I/opt/local/lib/gtk-2.0/include
-I/opt/local/include/atk-1.0 -I/opt/local/include/cairo
-I/opt/local/include/pango-1.0 -I/opt/local/include/glib-2.0
-I/opt/local/lib/glib-2.0/include -I/opt/local/include
-I/opt/local/include/freetype2 -I/opt/local/include/libpng12
-I/usr/X11R6/include -I/opt/local/include -I/opt/local/include -I/usr/include
-c sensorevent.c -MT sensorevent.lo -MD -MP -MF .deps/sensorevent.TPlo 
-fno-common -DPIC -o .libs/sensorevent.o
In file included from sensorevent.c:34:
packet-ipmb.h:30:15: warning: missing whitespace after the macro name
sensorevent.c: In function 'dissect_cmd_Set_Event_Receiver':
sensorevent.c:44: warning: unused parameter 'pinfo'
sensorevent.c:44: warning: unused parameter 'len'
sensorevent.c: In function 'dissect_cmd_Get_Event_Receiver':
sensorevent.c:99: warning: unused parameter 'pinfo'
sensorevent.c:99: warning: unused parameter 'len'
sensorevent.c: In function 'dissect_cmd_Set_Sensor_Event_Enable':
sensorevent.c:154: warning: unused parameter 'pinfo'
sensorevent.c: In function 'dissect_cmd_Get_Sensor_Event_Enable':
sensorevent.c:308: warning: unused parameter 'pinfo'
sensorevent.c: In function 'dissect_cmd_GetDeviceSDR':
sensorevent.c:655: warning: unused parameter 'auth_offset'
sensorevent.c: In function 'dissect_cmd_Get_Device_SDR_Info':
sensorevent.c:707: warning: unused parameter 'pinfo'
sensorevent.c:707: warning: unused parameter 'len'
sensorevent.c: In function 'dissect_cmd_Reserve_Device_SDR_Repository':
sensorevent.c:766: warning: unused parameter 'pinfo'
sensorevent.c:767: warning: unused parameter 'len'
sensorevent.c:767: warning: unused parameter 'auth_offset'
application.c: In function 'dissect_cmd_Send_Message':
application.c:1062: warning: 'completionCode' is used uninitialized in this
function

Most of them look pretty easy to fix. The WTAP_ENCAP_IPMB error implies that
there were wiretap changes that aren't present in the patch.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.