Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 2000] RTP Stream Analysis - Save Payload error with .enc files from Cisco NAM

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2000





------- Comment #7 from jaap.keuter@xxxxxxxxx  2007-11-25 15:04 GMT -------
Hmmm, I should drink some coffee before looking at this :)
Revisiting the captures and comment #6 makes me wonder if we should augment the
quoted part. The RTP dissector sets rtpinfo->info_all_data_present when it
checks for a complete payload. This flags should be added to the test, so that
both physical layer and application layer agree there's a problem. The physical
layer may think there is, but if the application layer is oke with it, we might
as well accept the payload.

-       /* if the captured length and packet length aren't equal, we quit
-       * because there is some information missing */
-       if (pinfo->fd->pkt_len != pinfo->fd->cap_len) {
+       /* if the captured length and packet length aren't equal, we quit
+       * if also the RTP dissector thinks there is some information missing */
+       if ((pinfo->fd->pkt_len != pinfo->fd->cap_len) &&
+           (!rtpinfo->info_all_data_present)) {
                saveinfo->saved = FALSE;
                saveinfo->error_type = TAP_RTP_WRONG_LENGTH;


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.