Wireshark-bugs: [Wireshark-bugs] [Bug 1974] Some enhancement for wimaxasncp
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 6 Nov 2007 14:22:10 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1974





------- Comment #5 from martin.r.mathieson@xxxxxxxxxxxxxx  2007-11-06 14:22 GMT -------
I've tested it with available captures here.  I don't know EAP at all, but I'm
told that it looks OK, although we've seen requests with string EAP-TLS
reassembled from fragments all over the test file.

The issue with the indentation wasn't the width of the tabs, it was that the
existing file uses space characters instead.

Looking at the way sminmpec is included:
- packet-wimaxasncp.c includes <epan/sminmpec.h>
- epan/sminmpec.h includes #defines for the symbols and this line:
WS_VAR_IMPORT const value_string sminmpec_values[];
- the file epan/libwireshark.def also includes the line:
sminmpec_values                 DATA

So something similar should be done for the copy/pasted parts taken from
packet-eap.c so that wimaxasncp catches any updates/improvements.



-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.