Wireshark-bugs: [Wireshark-bugs] [Bug 1956] Wireshark crashes on certain display filters (ftype
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 6 Nov 2007 13:26:57 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1956





------- Comment #6 from ellocodelassembler@xxxxxxxxx  2007-11-06 13:26 GMT -------
(In reply to comment #5)
> Fixed in SVN 23375.

Is this code below?
static gboolean
cmp_bitwise_and(fvalue_t *fv_a, fvalue_t *fv_b)
{
        guint32         addr_a;
        guint32         addr_b;

        addr_a = fv_a->value.ipv4.addr & fv_a->value.ipv4.nmask;
        addr_b = fv_b->value.ipv4.addr & fv_b->value.ipv4.nmask;
        return ((addr_a & addr_b) != 0);
}

Perhaps I missed something but, haven't you changed the semantics of the
operation?
In the original version was enough to have a zero after anding anyone of the
octets, but in this one seems that such restriction doesn't exists anymore.

I prefer this version, tough :D


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.