Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 1942] New: wrong value for GetDeviceID_data_DeviceSDR in ipmi dissector

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1942

           Summary: wrong value for GetDeviceID_data_DeviceSDR in ipmi
                    dissector
           Product: Wireshark
           Version: SVN
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: Normal
          Priority: Medium
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: stephane@xxxxxxxxxxxxx


Build Information:
build information irrelevant. I provide a patch on svn revision 23271, but
found the bug on 0.99.6
--
The description of the most significant bit of the "Device Revision" byte of
the response to a "Get Device ID" is the wrong way round. 1 means "device
provides Device SDRs" and not the contrary according to IPMI specs 1.5 and 2.0.

Also, I noticed in that file that "Chassis" is spelled "Chasis".

Here is a patch on revision 23271.

--- epan/dissectors/packet-ipmi.c~      2007-10-25 17:39:55.000000000 +0100
+++ epan/dissectors/packet-ipmi.c       2007-10-25 17:39:44.000000000 +0100
@@ -305,7 +305,7 @@ static int hf_GetDeviceID_datafield_Devi
 static int hf_GetDeviceID_datafield_MajorFirmwareRevision = -1;
 static int hf_GetDeviceID_datafield_MinorFirmwareRevision = -1;
 static int hf_GetDeviceID_datafield_IPMIRevision = -1;
-static int hf_GetDeviceID_datafield_ADS_Chasis = -1;
+static int hf_GetDeviceID_datafield_ADS_Chassis = -1;
 static int hf_GetDeviceID_datafield_ADS_Bridge = -1;
 static int hf_GetDeviceID_datafield_ADS_IPMBEventGenerator = -1;
 static int hf_GetDeviceID_datafield_ADS_IPMBEventReceiver = -1;
@@ -1191,8 +1191,8 @@ static const value_string cmd_GetSensorR

 /* Get Device ID data, added by lane*/
 static const value_string cmd_GetDeviceID_data_DeviceSDR_vals[] = {
-       { 0x00, "Device provides device SDR" },
-       { 0x01, "Device does not provide device SDR" },
+       { 0x00, "Device does not provide device SDR" },
+       { 0x01, "Device provides device SDR" },
        { 0x00, NULL },
 };

@@ -2418,7 +2418,7 @@ dissect_cmd_Get_Device_ID(proto_tree *tr

                        field_tree = proto_item_add_subtree(tf,
ett_cmd_GetDeviceID_data_ads);

-                       proto_tree_add_item(field_tree,
hf_GetDeviceID_datafield_ADS_Chasis,
+                       proto_tree_add_item(field_tree,
hf_GetDeviceID_datafield_ADS_Chassis,
                                    tvb, *poffset, 1, TRUE);
                        proto_tree_add_item(field_tree,
hf_GetDeviceID_datafield_ADS_Bridge,
                                    tvb, *poffset, 1, TRUE);
@@ -5042,10 +5042,10 @@ proto_register_ipmi(void)
                        "IPMI Revision", "GetDeviceID.datafield.IPMIRevision",
                        FT_UINT8, BASE_HEX,
VALS(cmd_GetDeviceID_Data_IPMIRevision_vals), 0,
                        "IPMI Revision", HFILL }},
-               { &hf_GetDeviceID_datafield_ADS_Chasis, {
-                       "Chasis Device", "GetDeviceID.datafield.Chasis",
+               { &hf_GetDeviceID_datafield_ADS_Chassis, {
+                       "Chassis Device", "GetDeviceID.datafield.Chassis",
                        FT_UINT8, BASE_HEX,
VALS(cmd_GetDeviceID_data_ADS_vals), 0x80,
-                       "Chasis Device", HFILL }},
+                       "Chassis Device", HFILL }},
                { &hf_GetDeviceID_datafield_ADS_Bridge, {
                        "Bridge Device", "GetDeviceID.datafield.Bridge",
                        FT_UINT8, BASE_HEX,
VALS(cmd_GetDeviceID_data_ADS_vals), 0x40,


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.