Wireshark-bugs: [Wireshark-bugs] [Bug 1870] new protocol dissector for the protocol PCE
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1870
------- Comment #19 from francesco.fondelli@xxxxxxxxx 2007-10-22 15:43 GMT -------
(In reply to comment #18)
> Created an attachment (id=1045)
--> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1045&action=view) [details]
> Traces of a complete session, and draft of PCE
Hi,
nice trace. I would suggest you few changes.
1)
PCEP objects are very similar to the ones used in
RSVP (some of them are even the same, like ERO).
I guess users would like to see PCEP messages
dissected and displayed in the same way.
Have a look at packet-rsvp.c. I try to use an example.
your way:
OPEN Header >
OPEN Body >
in rsvp-style would have been:
OPEN >
Length: xx
Object Class: yy
Object Type: 1
Flags >
Version: 1
Keepalive: 30s
Deadtimer: 120s
SID: 1234
IMHO the second form should be preferred. Moreover identical
objects (RSVP/PCEP) should be displayed exactly
in the same way (e.g. ERO).
(I'll attach a snapshot of a rsvp trace)
2)
The second point is the name of the protocol abbreviation, for me
it's pcep like tcp, ip, dccp, rsvp etc etc `p` is always there :-)
3)
Last but not least, if a message is defined in draft-ietf-pce-pcep-08.txt
without any Optional sub-TLV(s), you cannot add TLV1 TLV2 in your tree
as it would be normal... you should put a "malformed" label somewhere
or add an "Unknown Object" TLV like rsvp does. A user should be aware
that something weird/wrong is happening.
thanks a lot
Ciao
FF
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
