Wireshark-bugs: [Wireshark-bugs] [Bug 1897] eDonkey dissector update patch
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 11 Oct 2007 22:59:09 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1897





------- Comment #3 from stig@xxxxxxxxxxxxx  2007-10-11 22:59 GMT -------
I do not know this protocol, but I have some comments to the patch:
- I think the new value_string's should have a readable string instead of just
dumping the name of the define.
- You should use _add_item instead of _add_text for some of your elements (Tag
Type/Name, and probably more) to make them searchable.
- The tag string uses the filter prefix "edonkey" and the tag integer uses the
filter prefix "kademlia.tag".  I think they should have the same prefix.
- What about dumping "Name: Value" in the "Tag[1/4]" (and alike) subtree entry?
- How many port numbers do you register in the end of this patch?


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.