http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1606
------- Comment #7 from acferen@xxxxxxxxx 2007-10-08 14:06 GMT -------
(In reply to comment #6)
> (In reply to comment #5)
> > Created an attachment (id=940)
--> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=940&action=view) [details] [details]
> > Updated patch (addressing earlier comments)
> >
> > Issue 1 : Memory management
> > Honestly, I'm not quite sure what was going on there either. I pillaged the
> > code from packet-tcap.c and didn't give much thought to it. I have removed the
> > superfluous range variables and it is still working fine. I guess they weren't
> > needed.
>
> Actually, they are needed. As it was, your updated code was doing:
>
> + if (global_ipfix_ports) {
> + range_foreach(global_ipfix_ports, ipfix_delete_callback);
> + }
> [...]
> + range_foreach(global_ipfix_ports, ipfix_add_callback);
>
> (E.g., it was deleting and then re-adding the same ports--which would be the
> ones the user just changed the value to be. In other words if the user deleted
> some ports from the preference then that deletion would not take effect.)
>
> Sorry for the confusion on that one.
That helps. Thanks for taking the time to clarify that.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
