http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1430
PeterJohansson73@xxxxxxxxx changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #936|review_for_checkin? |
Flag| |
Attachment #936 is|0 |1
obsolete| |
Attachment #949| |review_for_checkin?
Flag| |
------- Comment #20 from PeterJohansson73@xxxxxxxxx 2007-09-24 13:20 GMT -------
Created an attachment (id=949)
--> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=949&action=view)
A complete set of files with plugin dissectors for EtherCAT
In reply to http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1430#c19 .
1. I have removed includes <gmodule.h> and "moduleinfo.h".
2. All unnamed unions have been assigned names.
3. The ethertype 0x88A4 has been added to etypes.h and packet-ethertype.c.
4. Module registration has been removed since no preferences exist. Btw, why
should registration not be made when preferences do not exist (apart from that
it is not needed)?
5. In what way is "#pragma pack(push, 1)" not portable? Are you referring to
that some compilers do not recognise the pragma pack statement or that it is
uncertain whether or not the data layout will be the same between platforms?
6. ams.h has been removed from the file makefile.common.
Additionally I have added code that verifies that the amount of PDU data that
is attempted to be copied using tvb_memcpy actually is available in the PDU
(using tvb_ensure_bytes_exist). This handles the case when malformed PDUs are
dissected.
Thank you for your feeedback!
Regards, Peter
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
