Wireshark-bugs: [Wireshark-bugs] [Bug 1445] Add ability to provide a "named subnets" file in add
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1445
jaap.keuter@xxxxxxxxx changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #563|review_for_checkin? |review_for_checkin-
Flag| |
------- Comment #5 from jaap.keuter@xxxxxxxxx 2007-07-30 14:34 GMT -------
(From update of attachment 563)
Idea is good, though quick review shows these:
>Index: docbook/wsug_src/WSUG_app_files.xml
>===================================================================
>+ <entry>/etc/subnets, $HOME/.wireshark/hosts</entry>
This should end in "/subnets</entry>"
>Index: epan/addr_resolv.c
>===================================================================
>+ subnet_name_len = strlen(subnet_entry.name);
>+ addr_len = strlen(paddr);
Why figuring out these lengths and not using them?
>+ /* XXX Prototype code
>+ inet_pton(AF_INET,"192.168.0.1", (guint8*)&i);
>+ subnet_entry_set(i, 4, "four");
>+ subnet_entry_set(i, 24, "twenty-four");
>+ subnet_entry_set(i, 8, "eight");
>+ subnet_entry_set(i, 16, "sixteen");
>+ subnet_entry_set(i, 12, "twelve");
>+ inet_pton(AF_INET,"192.168.0.2", (guint8*)&i);
>+ subnet_entry_set(i, 24, "twenty-four (b)");
>+ inet_pton(AF_INET,"192.192.0.2", (guint8*)&i);
>+ subnet_entry_set(i, 24, "twenty-four (c)");
>+ */
This shouldn't be in the patch.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
