Wireshark-bugs: [Wireshark-bugs] [Bug 1182] dumcap doens't compile with -Wall -Werror
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1182
------- Comment #2 from frederic.heem@xxxxxxxxx 2006-10-26 16:41 GMT -------
(In reply to comment #1)
> Yes, that is something I'd like to obtain too, but unfortunately, it's almost
> impossible to do:
> - There are many platforms involved. Some of the system include files generate
> warnings (e.g. gtkitemfactory.h:50: warning: function declaration isn’t a
> prototype) which is something we can't fix right now. Some warnings are just
> gcc mistakes (might be used uninitialized), so "fixing" those warnings would be
It would be nice to open a bug report for gtkitemfactory.h and gcc.
gtkitemfactory.h is used only for wireshark, not tshark.
Maybe it would be possible to set -Werror for tshark and dumpcap with cmake.
> just plain wrong. Another problem is that not all developers use gcc: Some use
> some windows build env without gcc (MSVC?) which does not warn on everything
> that gcc warns about - well, even gcc differs from agcc with a different
> version. So -Werror is not really an option.
of course, -Wall -Werror shall be added for gnu only.
>
> Don't get me wrong: I've been working on fixing compile time warnings for quite
> a long time and just gave up about a year ago because the rate at which new
> warnings were added was too high.
>
Good to know that someones care about warnings.
IMHO, at least new code shall compiled passed with -Werror, code that doesn-t
comply with this rule shall not be committed.
When gcc emit a warning, it may become an error with future gcc releases, it
happened a lot from gcc 3.x to 4.x
I understand that it's not a one man task. Why not asking every dissector
writers to fix their own warnings ?
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
