Wireshark-bugs: [Wireshark-bugs] [Bug 1179] cmake build integration + dbus + bunch of memleak fi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 26 Oct 2006 10:57:30 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1179





------- Comment #18 from frederic.heem@xxxxxxxxx  2006-10-26 10:57 GMT -------
(In reply to comment #17)
> Which file includes wiretap/libpcap.h - or capture_loop.h, which includes
> wiretap/libpcap.h - without including <glib.h> before it?  If no file does
> that, the code will compile without that change; the current SVN code compiles
> without that change.
> 

It doesn't matter which file include wiretap/libpcap.h - without including
<glib.h> before it. It matters that wiretap/libpcap.h shall include <glib.h>
inside it because it wiretap/libpcap.h depends on <glib.h>
It makes future changes much easier: suppose wiretap/libpcap.h wants to  change
its dependency from glib.h to another one. In the actual case where glib.h is
not included in wiretap/libpcap.h, one has to change every single file that
includes wiretap/libpcap.h and change glib.h to the other one.
In the case where wiretap/libpcap.h includes glib.h, one has to change only one
file. 
A solution which requires to modify only one file is much better than a
solution that has to modified many files.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.