Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 1179] cmake build integration + dbus + bunch of memleak fixes

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1179


ulf.lamping@xxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX




------- Comment #4 from ulf.lamping@xxxxxx  2006-10-24 13:46 GMT -------
DON'T put unrelated changes in a single patch and let the core developers do
the work of separate things from it (72kB is a fairly large patch) - for this
reason I'll mark this as WONTFIX.

You should try to separate the patch into smaller and "complete in itself"
parts - this will make inclusion much more probable.

You may start with the memleak fixes - I guess these will be small and can be
easily applied.

I don't know about the cmake changes - this might make sense to be included -
you might provide a smaller patch including only these changes as a second
step.

However, dumpcap should be kept very lean and mean to prevent any security
related bugs. Adding the dbus support (is this the KDE desktop control bus?) is
working against this design goal ... so this should be discussed in the devel
list first IMHO.

It *might* make more sense to create a dumpcap lib to collect the basic
routines, and several "frontends" for it - but didn't thought about it much for
now.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.