Wireshark-bugs: [Wireshark-bugs] [Bug 1110] Invalid characters in show attribute in PDML output
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1110
------- Comment #9 from paul.blankenbaker@xxxxxxxxxx 2006-09-26 17:47 GMT -------
I found this PDML Specification document (not sure how valid it is):
http://analyzer.mirror.ethereal.com/docs/dissectors/PDMLSpec.htm
It looks to me like both the "show" and "value" attributes are required.
Would setting these attributes to an empty string (ie: show="") be a reasonable
solution to this problem?
Paul
(In reply to comment #8)
> I didn't get any response to the patch I send to the wireshark-dev list a
> couple of weeks ago.
>
> http://www.wireshark.org/lists/wireshark-dev/200609/msg00499.html
>
> The code that that patch avoids running (for FT_NONE fields) will write out:
> - "show" attribute
> - "value" attribute
>
> These look to me as if they are only valid for fields that actually have a
> value (where show may be scaled or offset from the value read from the relevant
> bytes).
>
> My only question is:
> - according to the PDML schema, do these attributes need to be present? If so,
> would what should FT_NONE fields show here?
>
> If someone can either:
> - confirm that these attributes are optional, I'll submit the patch as-is, OR
> - tell me someone appropriate to output instead in the absence of having real
> values to report, I'll make it output that instead
>
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
