Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 1106] New: packet-lapd.c change on 2006-03-02 (17452) by etxrab swaps SRC/DST

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1106

           Summary: packet-lapd.c change on 2006-03-02 (17452) by etxrab
                    swaps SRC/DST for the default case
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: Blocker
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: rolf.fiedler@xxxxxxxxxxxxx


The following change to the code broke the Net/User display in src/dst columns:
in rev 15844
-       if (pinfo->p2p_dir == P2P_DIR_SENT) {
-               is_response = cr ? TRUE : FALSE;
-               if(check_col(pinfo->cinfo, COL_RES_DL_DST))
-                       col_set_str(pinfo->cinfo, COL_RES_DL_DST, "Network");
-               if(check_col(pinfo->cinfo, COL_RES_DL_SRC))
-                       col_set_str(pinfo->cinfo, COL_RES_DL_SRC, "User");

after rev 15844
+       else if (pinfo->p2p_dir == P2P_DIR_SENT) {
+               is_response = cr ? FALSE : TRUE;
+               srcname = "Network";
+               dstname = "User";

old src name was user, now src name is Network!

during adding the "we_network" logic for WTAP_ENCAP_LINUX_LAPD to
properly handle the cases were the probe is on network or user side

SENT and RECV has been swapped for the default case!!!

Please apply the following patch to make the default case operational again
This applies to all traces generated by Toshiba Routers or EyeSDN USB devices.
To reproduce the bug, simply open a Toshiba Router ISDN Trace with LAPD
contents and check RX/TX in the Trace file vs. the Network/User labeling.
Everything works fine before Rev 17452.

thank you,
Rolf
===============
Index: epan/dissectors/packet-lapd.c
===================================================================
--- epan/dissectors/packet-lapd.c       (Revision 19234)
+++ epan/dissectors/packet-lapd.c       (Arbeitskopie)
@@ -176,12 +176,12 @@
                        }
                }
        }
-       else if (pinfo->p2p_dir == P2P_DIR_SENT) {
+       else if (pinfo->p2p_dir == P2P_DIR_RECV) {
                is_response = cr ? FALSE : TRUE;
                srcname = "Network";
                dstname = "User";
        }
-       else if (pinfo->p2p_dir == P2P_DIR_RECV) {
+       else if (pinfo->p2p_dir == P2P_DIR_SENT) {
                is_response = cr ? TRUE : FALSE;
                srcname = "User";
                dstname = "Network";


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.