Wireshark-bugs: [Wireshark-bugs] [Bug 1015] buffer overflow in nettl.c due renaming ethereal
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 27 Jul 2006 08:23:26 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1015





------- Comment #5 from guy@xxxxxxxxxxxx  2006-07-27 08:23 GMT -------
Perhaps, although if the intent is to ensure that the string in question appear
in the header, strlcpy() would fail to do that without failing in any way other
than returning a value greater than the size of the target.  The *best* fix
might be to put an empty string in the host name; that'd be guaranteed to fit,
and be guaranteed not to make a false claim about the machine on which the file
was captured.  Unless other programs reading nettl captures would fail with an
empty string, that's probably the best choice.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.