Wireshark · Ethereal-users: Re: [Ethereal-users] Ethereal SIP Bugs?

["Martin Regner" <martin.regner@xxxxxxxxx>]

Scott Holben wrote:
<With Ethereal version 0.9.7 on a Windows box and WinPcap version 2.3, has
<anyone out there noticed any strange problems with Ethereal not capturing
<properly or improperly printing text files of SIP messages containing
<"Authorization:" or "Proxy-Authorization:" fields?
<
<The SIP messages I am examining, containing these headers, are looking
<stranger as my testing continues.  Look at the end of the following sniffed
<headers.
<
<Examples:
<
<Authorization: DIGEST USERNAME="SIPhelp", REALM="Registered Users",
<NONCE="1331021128100703", URI="sip:sip.acme.com",
<RESPONSE="fcec5335bcf4e3682f0bd83ba85c5df6",
<CNONCE="9a2ec90a6f6bb6c501cbda866aed0a2f",
<OPAQUE="133102112810070Content-Length: 0
<
<Proxy-Authorization: DIGEST USERNAME="john.doe", REALM="Registered Users",
<NONCE="1501021148461202", URI="sip:phone2@xxxxxxxxxxxx",
<RESPONSE="0e209dcc3b146ae857ed6274248c630f",
<CNONCE="9074acf8bb026f59ee7e172f216b31e3", OPAQUUser-Agent: Pingtel/2.0.2
<(VxWorks)


Some problem seems to occur sometimes when printing strings that are longer than ITEM_LABEL_LENGTH
 (default value 240) on the Windows version of Ethereal.

I agree with you and Ronald Henderson that it it would be good if it would be possible to configure
this length in some way without having to recompile. I have not looked into that yet.

But I have looked into the problem with your strange printouts at the end of the lines, the problem
Ronald Henderson had with blank lines in his LDAP captures, and the problem I had with 
some captures.

It seems that these problems can be avoided by setting a null character for index ITEMLENGTH - 1
of the result from vsnprinttf/snprintf in some places.

Currently I have set 
label_str[ITEM_LABEL_LENGTH - 1] = '\0';
in proto.c/proto_item_fill_label(...)

and
fi->representation[ITEM_LABEL_LENGTH - 1] = '\0';
in proto.c/proto_tree_set_representation(..)

Then I get good results for both some SIP-capture I modified and Ronald's LDAP-captures
(I got good result both when printing and viewing on screen). The lines are truncated correct, instead of shown as
blank lines or with some crap at the end of the lines.

I used the following LDAP captures:
http://www.ethereal.com/lists/ethereal-users/200211/msg00089.html
http://www.ethereal.com/lists/ethereal-users/200211/msg00105.html

I have attached one of the SIP-captures I used for reproducing the problem.
With the Ethereal 0.9.7 on Windows you get a "Content-Length: 0" last on the line starting
with "Server: Columbia-SIP-Server/1bia-" that shouldn't really be there.

I have also noticed that I get blank lines on Windows when a string includes a character with ascii value greater than 127.
I got rid of that problem by making a small change in epan/strutil.h format_text(...) so that
characters with ascii value greater than 127 is printed in same way as non printable characters, printing them in octal format
e.g. as \233.

I'm not sure I will have time to investigate this further, test it and produce some patch in the near future, 
so if someone else have possibility to look into this it would be good.

Session Initiation Protocol
    Status line: SIP/2.0 100 Trying
    Message Header
        Via: SIP/2.0/UDP 130.230.83.28:5060
        From: sip:tltsip1@130.230.83.28
        To: <sip:54321@130.230.52.22>
        Call-ID: c3943000-28eb7f0-7c3f6c-2e303331@130.230.83.28
        Cseq: 100 INVITE
        Date: Fri, 03 Nov 2000 11:55:03 GMT
        Server: Columbia-SIP-Server/1bia-SIP-Server/2bia-SIP-Server/3bia-SIP-Server/4bia-SIP-Server/5bia-SIP-Server/6bia-SIP-Server/7bia-SIP-Server/8bia-SIP-Server/9bia-SIP-Server/:bia-SIP-Server/;bia-SIP-Server/<bia-SIP-Server/=bia-SIP-Server/>biaContent-Length: 0
        Content-Length: 0

0000  00 30 94 c3 f0 b7 00 30 80 da 9f e0 08 00 45 00   .0.....0......E.
0010  02 1b 34 ac 00 00 3e 11 ba 07 82 e6 34 16 82 e6   ..4...>.....4...
0020  53 1c 04 33 13 c4 01 f7 34 af 53 49 50 2f 32 2e   S..3....4.SIP/2.
0030  30 20 31 30 30 20 54 72 79 69 6e 67 0d 0a 56 69   0 100 Trying..Vi
0040  61 3a 20 53 49 50 2f 32 2e 30 2f 55 44 50 20 31   a: SIP/2.0/UDP 1
0050  33 30 2e 32 33 30 2e 38 33 2e 32 38 3a 35 30 36   30.230.83.28:506
0060  30 0d 0a 46 72 6f 6d 3a 20 73 69 70 3a 74 6c 74   0..From: sip:tlt
0070  73 69 70 31 40 31 33 30 2e 32 33 30 2e 38 33 2e   sip1@130.230.83.
0080  32 38 0d 0a 54 6f 3a 20 3c 73 69 70 3a 35 34 33   28..To: <sip:543
0090  32 31 40 31 33 30 2e 32 33 30 2e 35 32 2e 32 32   21@130.230.52.22
00a0  3e 0d 0a 43 61 6c 6c 2d 49 44 3a 20 63 33 39 34   >..Call-ID: c394
00b0  33 30 30 30 2d 32 38 65 62 37 66 30 2d 37 63 33   3000-28eb7f0-7c3
00c0  66 36 63 2d 32 65 33 30 33 33 33 31 40 31 33 30   f6c-2e303331@130
00d0  2e 32 33 30 2e 38 33 2e 32 38 0d 0a 43 73 65 71   .230.83.28..Cseq
00e0  3a 20 31 30 30 20 49 4e 56 49 54 45 0d 0a 44 61   : 100 INVITE..Da
00f0  74 65 3a 20 46 72 69 2c 20 30 33 20 4e 6f 76 20   te: Fri, 03 Nov 
0100  32 30 30 30 20 31 31 3a 35 35 3a 30 33 20 47 4d   2000 11:55:03 GM
0110  54 0d 0a 53 65 72 76 65 72 3a 20 43 6f 6c 75 6d   T..Server: Colum
0120  62 69 61 2d 53 49 50 2d 53 65 72 76 65 72 2f 31   bia-SIP-Server/1
0130  62 69 61 2d 53 49 50 2d 53 65 72 76 65 72 2f 32   bia-SIP-Server/2
0140  62 69 61 2d 53 49 50 2d 53 65 72 76 65 72 2f 33   bia-SIP-Server/3
0150  62 69 61 2d 53 49 50 2d 53 65 72 76 65 72 2f 34   bia-SIP-Server/4
0160  62 69 61 2d 53 49 50 2d 53 65 72 76 65 72 2f 35   bia-SIP-Server/5
0170  62 69 61 2d 53 49 50 2d 53 65 72 76 65 72 2f 36   bia-SIP-Server/6
0180  62 69 61 2d 53 49 50 2d 53 65 72 76 65 72 2f 37   bia-SIP-Server/7
0190  62 69 61 2d 53 49 50 2d 53 65 72 76 65 72 2f 38   bia-SIP-Server/8
01a0  62 69 61 2d 53 49 50 2d 53 65 72 76 65 72 2f 39   bia-SIP-Server/9
01b0  62 69 61 2d 53 49 50 2d 53 65 72 76 65 72 2f 3a   bia-SIP-Server/:
01c0  62 69 61 2d 53 49 50 2d 53 65 72 76 65 72 2f 3b   bia-SIP-Server/;
01d0  62 69 61 2d 53 49 50 2d 53 65 72 76 65 72 2f 3c   bia-SIP-Server/<
01e0  62 69 61 2d 53 49 50 2d 53 65 72 76 65 72 2f 3d   bia-SIP-Server/=
01f0  62 69 61 2d 53 49 50 2d 53 65 72 76 65 72 2f 3e   bia-SIP-Server/>
0200  62 69 61 2d 53 49 50 2d 53 65 72 76 65 72 2f 3f   bia-SIP-Server/?
0210  2e 30 0d 0a 43 6f 6e 74 65 6e 74 2d 4c 65 6e 67   .0..Content-Leng
0220  74 68 3a 20 30 0d 0a 0d 0a 13 c7 ae f0            th: 0........


Regards,
 Martin

Attachment: sipex.pcap7
Description: Binary data