Ethereal-users: Re: [ethereal-users] LDAP Dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Wed, 23 Aug 2000 15:59:33 -0700 (PDT)
> In parse_filter_substrings, the string pointer is NULL, and string_length
> is 0, but the dissector doesn't check that. Guy, do you want to take a
> look at that, since you have more experience with the ASN.1 string
> functions?

Yes, I'll take a look at this; callers to
"asn1_octet_string_value_decode()" must not assume that what they get
back is a '\0'-terminated string (it's a counted string, and it's not
even necessarily a character string - the ASN.1 dissector doesn't know
whether it is, although its caller probably does), *and* must not assume
that it gets back a non-null pointer.  The LDAP dissector is making both
of those assumptions in some places....