Ethereal-dev: Re: [Ethereal-dev] Re: Patch for new dissector plugin for Ether-S-Bus telegrams
On Tue, 20 Jun 2006, Christian Durrer wrote:
> Hi,
>
> I've uploaded a sample capture and created a protocol page on the Wiki
> (and modified the FieldbusProtocolFamily page a bit):
> http://wiki.ethereal.com/EtherSBus
> http://wiki.ethereal.com/SampleCaptures?action=AttachFile&do=get&target=sbus.pcap
> http://wiki.ethereal.com/FieldbusProtocolFamily
Very good. I've downloaded the capture file and fuzztested it against the
my plugin. Over 5000 runs without a problem. :)
Guy Harris and I have ported the Wiki pages to Wireshark. As you may well
know the core developers have moved to Wireshark, the continuation of
Ethereal(tm) development. That is we're I intent to add the dissector.
I've done some major cleanup of the code after all, to improve
readability. Removed some left over debug code, replaced some more
literals by their respective symbols, but most importantly changed the
strings of if statements into switches.
I'll try to get the code committed tomorrow, since it's past midnight
here and there is bound to be an error when I start now. :)
> Regarding the UDP port 5050: Yes, Ether-S-Bus always uses UDP port 5050.
> This is hardcoded in the firmware of the PLCs. I also know that the port
> 5050 is used for the mmcc service and already asked our development and
> product manager about this fact (but I asked after the protocol already
> had been introduced so no modification was made at this point to avoid
> any incompatibilities).
> According to our product manager this port has been free at the time
> this port was fixed for Ether-S-Bus or at least there was no risk for
> any conflict seen from the technical point...
I get the picture, too bad it's IANA that assigns port numbers to
applications. Now we end up with various kinds of services running on the
same port. In this case a clash is unlikely, but still goes against the
concept of finding a service at a certain port. Makes life simpler for
sniffers too. :/
Thanx,
Jaap
>
> On Mon, 2006-06-19 at 12:00 -0500, ethereal-dev-request@xxxxxxxxxxxx
> wrote:
>
> > Message: 1
> > Date: Sun, 18 Jun 2006 19:30:57 +0200 (CEST)
> > From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
> > Subject: Re: [Ethereal-dev] Re: Patch for new dissector plugin for
> > Ether-S-Bus telegrams modified (Jaap Keuter)
> > To: Ethereal development <ethereal-dev@xxxxxxxxxxxx>
> > Message-ID: <20060618192830.Y73562-100000@xxxxxxxxxxxxx>
> > Content-Type: TEXT/PLAIN; charset=US-ASCII
> >
> > Hi,
> >
> > Could you provide one or two sample capture files on the Wiki?
> > These can than be used to fuzztest the dissector.
> >
> > Could you create a protocol page on the Wiki with some information on the
> > protocol?
> >
> > Is the protocol always on port 5050? According to IANA this is used for
> > mmcc service.
> >
> > Thanx,
> > Jaap
> >
> > On Thu, 15 Jun 2006, Christian Durrer wrote:
> >
> > > Hi,
> > >
> > > thank you for your feedback. I finally managed to modify my code by
> > > - using symbols instead of hardcoded command codes
> > > - removing the debug code
> > > - removing the last set in the patch
> > > - adding the Makefile.common in the plugins dir
> > >
> > > Could you please have a look at it and if it is ok, check it in?
> > >
> > > Thanx,
> > > chris
> > >
> > >
> > >
> > > On Sun, 2006-06-04 at 12:00 -0500, ethereal-dev-request@xxxxxxxxxxxx
> > > wrote:
> > > > Send Ethereal-dev mailing list submissions to
> > > > ethereal-dev@xxxxxxxxxxxx
> > > >
> > > > To subscribe or unsubscribe via the World Wide Web, visit
> > > > http://www.ethereal.com/mailman/listinfo/ethereal-dev
> > > > or, via email, send a message with subject or body 'help' to
> > > > ethereal-dev-request@xxxxxxxxxxxx
> > > >
> > > > You can reach the person managing the list at
> > > > ethereal-dev-owner@xxxxxxxxxxxx
> > > >
>
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev
