Wireshark · Ethereal-dev: Re: [Ethereal-dev] Patch for new dissector plugin for Ether-S-Bus telegrams

[Jaap Keuter <jaap.keuter@xxxxxxxxx>]

Hi,

This looks pretty good, thanks.

A few small remark though:
1. could you use meaningfull symbols in the code i.s.o. hardcoded values.
I'm refering to code like this:

+                     if (((request_val->cmd_code) == 0x00) ||
+                            ((request_val->cmd_code) == 0x06) ||
+                            ((request_val->cmd_code) == 0x07) ||
+                            ((request_val->cmd_code) == 0x1E) ||
+                            ((request_val->cmd_code) == 0x1F) ||
+                            ((request_val->cmd_code) == 0xA1)){

2. Could you clean up the code a bit by removing the debug code from it

3. The last change in the set is superflous.

Thanx,
Jaap



On Sat, 3 Jun 2006, Christian Durrer wrote:

> Hi,
>
> I hope this is the right place to send a patch for a new dissector
> plugin. The telegram it dissects are for the communication between PLCs
> (Programmable logic controller) from the company Saia Burgess Controls
> Ltd. (http://www.start-controls.com, http://www.saia-burgess.com or
> http://www.sbc-support.ch). The protocol is named Ether-S-Bus (the PLCs
> are called PCD2, PCD3, PCD4).
> We developped this dissector for easyer debugging of networks containing
> our contollers.
>
> The patch was created against Ethereal Version 1.1.0 (SVN Rev 18189). I
> tested it with various capture files (which some of them also fuzzed).
> The VariousSBus is one of them.
>
> I also would like to make you a big compliment! Ethereal is a great
> tool!
>
> I'm available for any your questions
>
> With best regards
>
> Christian Durrer
>

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev