Ethereal-dev: Re: [Ethereal-dev] Patch: BUG: H323 VoIP Calls not working

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Cvetan Ivanov <zezo@xxxxxxxxx>
Date: Thu, 01 Jun 2006 13:31:25 +0300
Hello,

Thomas Sillaber wrote:
Hola List,

the Voip Calls Feature is not working correctly with H.323 (SIP is working).
 The Calls are not reassembled correctly. For every packet a new line is
displayed.

It seems to me that in gtk/voip_calls.c tmp_h323info->guid is pointer itself, therefore:
memcmp(&tmp_h323info->guid
should in fact read:
memcmp(tmp_h323info->guid

Attached is a one line patch that seems to fix the h323 call graph for me.

Best regards,

Cvetan

--
Cvetan Ivanov
System Administrator
SpectrumNet Jsc.
+35929657613 Office
Index: gtk/voip_calls.c
===================================================================
--- gtk/voip_calls.c	(revision 18189)
+++ gtk/voip_calls.c	(working copy)
@@ -1698,7 +1698,7 @@
 			tmp_listinfo=list->data;
 			if (tmp_listinfo->protocol == VOIP_H323){
 				tmp_h323info = tmp_listinfo->prot_info;
-				if ( (memcmp(&tmp_h323info->guid, &guid_allzero, GUID_LEN) != 0) && (memcmp(&tmp_h323info->guid, &pi->guid,GUID_LEN)==0) ){ 
+				if ( (memcmp(tmp_h323info->guid, &guid_allzero, GUID_LEN) != 0) && (memcmp(tmp_h323info->guid, &pi->guid,GUID_LEN)==0) ){ 
 					strinfo = (voip_calls_info_t*)(list->data);
 					break;
 				}
_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev