Wireshark · Ethereal-dev: Re: SV: [Ethereal-dev] Patch: enable explicit GIOP dissectors

["W. Borgert" <debacle@xxxxxxxxxx>]

On Mon, Apr 17, 2006 at 01:18:49AM +0200, Anders Broman wrote:
> Checked in.

Hey, thanks! :-)

> I don't have access to a Linux box to re generate the dissectors at the
> moment but will try to do it later this week.

Of course, I can generate the files. However, because the
order of e.g. exception decoding is somewhat coincidental,
the diff becomes much bigger than really necessary (825k).
Shall I send it to you (privately) anyway?

Maybe it would be a good idea to use .sort() on one or two
of the lists in ethereal_gen.py to make generated files
more diff-friendly in the future. A patch for this is
attached, but not thoroughly tested yet.

Cheers,
-- 
W. Borgert <debacle@xxxxxxxxxx>, http://people.debian.org/~debacle/

diff -uraN ethereal.orig/ethereal_gen.py ethereal/ethereal_gen.py
--- ethereal.orig/ethereal_gen.py	2006-04-17 10:38:44.000000000 +0000
+++ ethereal/ethereal_gen.py	2006-04-17 10:38:54.000000000 +0000
@@ -1525,8 +1525,9 @@
             sn = idlutil.slashName(sc1)         # penguin/tux
             if not int_hash.has_key(sn):
                 int_hash[sn] = 0;       # dummy val, but at least key is unique
-
-        return int_hash.keys()
+        ret = int_hash.keys()
+        ret.sort()
+        return ret
 
 
 
@@ -1547,8 +1548,9 @@
                     ex_hash[ex] = 0; # dummy val, but at least key is unique
                     if self.DEBUG:
                         print "XXX Exception = " + ex.identifier()
-
-        return ex_hash.keys()
+        ret = ex_hash.keys()
+        ret.sort()
+        return ret