Ethereal-dev: [Ethereal-dev] BACnet packet-bacapp corrections

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Steve Karg <skarg@xxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 15 Apr 2006 14:40:56 -0400
Hi Developers!

This patch corrects:
1) BACnet signed values were being decoded incorrectly for negative values since BACnet tries to be clever and minimizes the number of bytes sent on the wire and drops the leading FF on negative values. For example, -200 is passed as FF 38 on the wire, but would display as 65336.
2) Since the BACnet unsigned values were decoded using a 64-bit entity, I changed the decoding such that allows all 8 bytes to be decoded. The function can now decode 5, 6, and 7 byte values. 

3) Corrected warning about signed/unsigned in a pointer parameter.

Best Regards,

Steve

Attachment: bacapp.patch.gz
Description: GNU Zip compressed data