Ethereal-dev: Re: [Ethereal-dev] Patch for packet-bacapp.c for bug 793 and a few as yet unlogg

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Sat, 18 Mar 2006 10:42:37 +0100 (CET)
Hi,

I'm sorry but your patch seems broken:

packet-bacapp.c: In function 'fAcknowledgeAlarmRequest':
packet-bacapp.c:3517: error: too many arguments to function 'fTimeStamp'
packet-bacapp.c:3525: error: too many arguments to function 'fTimeStamp'
make[4]: *** [packet-bacapp.lo] Error 1

Thanx,
Jaap

On Sat, 18 Mar 2006, David Richards wrote:

> Patch that fixes bug 793 and a few other things mostly revolving around
> BACnet schedules.  Could someone please take care of this?
>
> 1) fDate - correctly handle wild card year
> 2) fTime - rename local variables cut-and-pasted from fDate
> 3) fCalendarEntry - do single-pass decoding rather than while loop since
> the structure cannot be repeated.
> 4) fDailySchedule - correctly handle enclosing context tags.
> 5) fWeeklySchedule - correctly handle enclosing context tags
> 6) fAcknowledgeAlarmRequest - fix function name spelling and tags 3 and
> 5 are timeStamp, not time.
> 7) fSpecialEvent - handle context tags correctly.
> 8) fReadRangeRequest - Add cases from 2004 spec
>
>
> Dave Richards
>