Ethereal-dev: Re: [Ethereal-dev] VoIP Calls Flow Feature not working

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date: Wed, 22 Feb 2006 01:41:05 +0100
I commented out the code to avoid a flaw in the GTK I got installed (
and commited it by mistake with a lot of other changes).

I fixed it in 17363


On 2/21/06, Alejandro Vaquero <alejandrovaquero@xxxxxxxxx> wrote:
> Hi List,
>    From the latest SVN, I see someone commented the GTK 2 code regarding
> displaying the "Comments" and "Label" in the "Graph Analysis", here a
> extract of graph_analysis.c:
>
>         /*draw the comments */
>         g_snprintf(label_string, MAX_COMMENT, "%s",
> user_data->dlg.items[current_item].comment);
> #if GTK_MAJOR_VERSION < 2
>         label_width=gdk_string_width(small_font, label_string);
>         label_height=gdk_string_height(small_font, label_string);
>         gdk_draw_string(user_data->dlg.pixmap_comments,
>                 small_font,
>                 user_data->dlg.draw_area_comments->style->black_gc,
>                 2,
>
> top_y_border+current_item*ITEM_HEIGHT+ITEM_HEIGHT/2+label_height/4,
>                 label_string);
> #else
>         /*
>         pango_layout_set_text(small_layout, label_string, -1);
>         pango_layout_get_pixel_size(small_layout, &label_width,
> &label_height);
>         if (GDK_IS_DRAWABLE(user_data->dlg.pixmap_comments)) {
>             gdk_draw_layout(user_data->dlg.pixmap_comments,
>                             user_data->dlg.draw_area->style->black_gc,
>                             2,
>
> top_y_border+current_item*ITEM_HEIGHT+ITEM_HEIGHT/2-label_height/2,
>                             small_layout);
>         }
>          */
> #endif
>
>
> I was trying to fix a problem in H323, but looks someone is working on
> this?! Any reason for commenting the GTK2 code?
>
> Thanks
> Alejandro
>
>
>
>
> Thomas Sillaber wrote:
> > Hello,
> >
> > SVN 17307:
> >
> > the VoIP Calls-Graph Feature display no Protokoll Informations only Numbers.
> > Saving the Graph to a file, it contains the Descriptions:
> >
> > |Time     | 10.1.100.20       | 10.1.100.21       |
> > |0,026    |         setup OLC ( nonStd nonStd)          |H225 From:
> > To:03039984300  TunnH245:on FS:on
> > |         |(16011)  ------------------>  (1720)   |
> > |0,028    |         setup OLC ( nonStd nonStd)          |H225 From:
> > To:03039984300  TunnH245:on FS:on
> > |         |(16011)  ------------------>  (1720)   |
> > |0,076    |         facility  |                   |H225 TunnH245:on FS:on
> > |         |(16011)  <------------------  (1720)   |
> >
> > Repruducable with any H.323 Capture.
> >
> > Any idea how to fix this?
> >
> >
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>


--
This information is top security. When you have read it, destroy yourself.
-- Marshall McLuhan