Ethereal-dev: Re: [Ethereal-dev] memory leak in expert_set_info_vformat (epan/expert.c)
I fixed it in revision 17293, was much easier than I thought as the
tap gets called only once so the object is se_copied only once...
I thought something harder like havng to keep track of which pieces
were already allocated and which not... remembrances of my h248
nightmare...
Luis
On 2/13/06, LEGO <luis.ontanon@xxxxxxxxx> wrote:
> A tough one too... No simple solution for this one.
> It looks like there's no way to know if we have already allocated the
> current one.
> No hashing possible (we can have two different identical items).
>
> I think we have to use ep_alloc instead of se_alloc in
> expert_set_info_vformat() and if needed copy the record in the
> consumer (expert_tap).
>
>
>
> On 2/13/06, didier <dgautheron@xxxxxxxx> wrote:
> > Hi
> > Memory allocated with se_alloc is only freed in rescan_packets if
> > redissect is true. So expert_info leaks memory rather quickly if you do
> > a lot of filtering.
> >
> > Didier
> >
> > _______________________________________________
> > Ethereal-dev mailing list
> > Ethereal-dev@xxxxxxxxxxxx
> > http://www.ethereal.com/mailman/listinfo/ethereal-dev
> >
>
>
> --
> This information is top security. When you have read it, destroy yourself.
> -- Marshall McLuhan
>
--
This information is top security. When you have read it, destroy yourself.
-- Marshall McLuhan
