Hi,
I checked in a variant of your patch.
I also made it not put ACK:<number> in the decode pane for the
expansion for TCP.
On 12/22/05, Bill Meier <wmeier@xxxxxxxxxxx> wrote:
> This is a small point and I don't know how others may feel, but I suggest
> that the TCP summary INFO column should not show ack= and win= information
> if the TCP header for that packet does not have the ACK flag set.
>
> Two cases where a TCP header does not have the ACK flag set are:
> 1. Originating initial SYN packets;
> 2. Certain RST packets;
>
> If there is agreement on this then the patch to packet-tcp.c to make this
> change
> is as below.
>
> Bill Meier
>
>
> @@ -2814,8 +2814,12 @@
> }
>
> if (check_col(pinfo->cinfo, COL_INFO)) {
> - col_append_fstr(pinfo->cinfo, COL_INFO, " [%s] Seq=%u Ack=%u Win=%u",
> - flags, tcph->th_seq, tcph->th_ack, tcph->th_win);
> + col_append_fstr(pinfo->cinfo, COL_INFO, " [%s] Seq=%u",
> + flags, tcph->th_seq);
> + if (tcph->th_flags & TH_ACK) {
> + col_append_fstr(pinfo->cinfo, COL_INFO, " Ack=%u Win=%u",
> + tcph->th_ack, tcph->th_win);
> + }
> }
>
> if (tree) {
>
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
