Hello Brian,
It looks the bug you have identified in the dissect_media_tlv()
function has already been identified and fixed in the most
recent change to packet-lldp.c SVN 16822 (2005-12-16).
This had been identified as bug 596.
There's been several enhancements to packet-lldp.c since my small
contributions applied on 2005-09-19 by Joerg .
FYI: To produce a useful patch is pretty easy if you have a good
(i.e. GNU utils) "diff" tool. There are a number of various diff formats
and all are not created equal. I believe the preferred diff output
format for generating patches is know as a "unified diff" file. This can
be produced with the command "diff -u oldfile newfile >changes.patch".
I believe the "svn diff" command produces this this type of output as
well.
I hope you find this info useful.
Jim Young
>>> brian_bogora@xxxxxxxxx 12/20/05 11:02 AM >>>
> There is a bug in the lldp dissector, specifically in the Network Policy
> portion of a Media TLV. The 5th byte was being used to get the DSCP
> value instead of the 4th....As I don't know how to create a .patch file,
> I attached the .c file...
>
> Brian
>
>> Joerg Mayer wrote:
>>On Sun, Sep 18, 2005 at 03:42:54AM -0400, Jim Young wrote:
>>
>>
>>The changes to the packet-lldp.c file includes elaborating on the values of the
>>803.3 "PMD Auto-Negotiation Advertised Capability" and "Operational MAU Type"
>>fields to also print the decimal value of "VLAN Identification" fields (in addition to
>>the hex value).
>>
>>
>
>applied
>
>Thanks
> Joerg
>
>
>
