Greg Morris wrote:
Has anyone had a chance to look at the submission from 11-11-05?
Checked in.
Hopefully, this time I did the add of the new files right (and didn't
forgot about a detail this time) ...
I've done some changes:
- changed file names and comments from comp_expert to expert_comp, so
both expert related features will be closer together in the sources.
- changed match_strval (which may return NULL) into val_to_str
- context menu: "Find Error on Internet" -> "Internet Search for Info Text"
Some things remain (please fix before submitting any new features):
- in comparison: composite code is *much* slower than log code (31s vs.
7s for the same 8MB file!). This will become essential when working with
very large files.
- the context menu items still seems to be very confusing (e.g. as
there's a "Goto First Occurance" why isn't there a "Goto Next Occurance"?)
- don't use the term "error" in the source code naming for the
"entries"? everywhere in the code. We have warn/note/chat levels as
well, so error is simply misleading.
- at least rename the functions and typedef's in the .h files with a
*meaningful* prefix: init_error_table -> expert_comp_table_init
(renaming the prefixes in all of the files makes sense too)
Looking forward to your fixes ...
Regards, ULFL
P.S: Sorry for any delay, still very busy ...
