Ethereal-dev: [Ethereal-dev] [PATCH] Q.931 fails to pass long message to H.225

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Wed, 16 Nov 2005 17:54:34 +0100 (CET)
Hi list,

Someone tossed me this capture which he expected to be reassembled. We
checked all the reassemble check boxes on TCP, TPKT, Q.931 but to no
avail. Searching through the code I came up with this oneliner, which
does not accomplish reassembly, but does break the dissection less
severly.

Thanx,
Jaap

Attachment: splitq931.cap
Description: Binary data

Index: packet-q931.c
===================================================================
--- packet-q931.c	(revision 16507)
+++ packet-q931.c	(working copy)
@@ -2624,6 +2624,7 @@
 			}
 
 			if (info_element_len > 1) {
+				info_element_len = min(info_element_len, tvb_length_remaining(tvb, offset + 4));
 				/*
 				 * Do we have a handle for the H.225
 				 * dissector?