Ethereal-dev: Re: [Ethereal-dev] [Patch] eth_mkdir()

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Sat, 12 Nov 2005 17:53:59 +0100
Gisle Vanem wrote:


Ops, should be:


checked in.

Hmmm, some things:
Please *attach* patches, and don't just simply include it into the mail text, see the developer's guide for reasons why. 
The Win32 API function is called _mkdir and not simply mkdir.
Using macro parameter names a,b,c is very short, but please learn to use meaningful names. If you do know the parameters for the mkdir function, nice, but don't expect others to know that as well. That's very important for maintenance and understandable code.
Although your patch was better than nothing, I had to do the changes by hand and also fix the bug that way ... 

Regards, ULFL