Wireshark · Ethereal-dev: Re: [Ethereal-dev] Stopping the load of a capture file [PATCH]

[Guy Harris <gharris@xxxxxxxxx>]

Ulf Lamping wrote:
> Guy Harris wrote:
>
> > Given that it's really not cancelling the load - it doesn't undo all 
> > the stuff done as part of the load - should the button say "Stop" 
> > rather than "Cancel"?
>
> I've thought about that too but was simply just too lazy. This dialog 
> should really use a stop button, but we currently don't have a way to 
> show it this way with the progressbar code. However, it shouldn't be too 
> difficult to implement.

I've checked in a change to add a Boolean to the functions to create 
dialog boxes, specifying whether the "terminate" button should be a 
"Stop" button or a "Cancel" button, and modified the calls appropriately.

> > Also, do other places that read files, e.g. the file merge code, check 
> > for the stop button and stop the operation?
>
> Loading the file was simply the first thing that came into mind.

The merge code wasn't checking for the stop button being clicked; I 
added code to do that (it's a cancellable operation - it can just not 
bother reading the new file - and you *might* lose some packets already 
read in if you stop it and read the file rather than just not bothering 
to read the new file).