Wireshark · Ethereal-dev: Re: [Ethereal-dev] New GLib file-related call changes

[Ulf Lamping <ulf.lamping@xxxxxx>]

Guy Harris wrote:

> ulfl@xxxxxxxxxxxx wrote:
>
> > As of these massive changes, I'm almost certain that this will break
> > the Unix build. I'll keep an eye on the buildbot so hopefully everything
> > is working again soon.
>
>
> Actually, the first build that broke was the Win32 build; 
> <glib/gstdio.h> *is* GLib 2.6-only.

Yes, I've fixed that one already ;-)

> Also, the build is failing for me, as "wiretap/file_util.h" includes 
> "mkstemp.h", but "mkstemp.h" is in the top-level directory, and the 
> build of Wiretap doesn't do "-I..".

Ok, when I remember this correct, wiretap itself doesn't use mkstemp, so 
no need to include it from wiretap.

> I'm not sure where the abstraction of the low-level file access 
> routines should be done.  Wiretap *could* be the right place, although 
> the stuff it currently handles is a bit higher-level than that; 
> another possibility would be to have another library that just handles 
> that.

Another lib *might* be a bit oversized (but I'm not sure).

> In either case, whatever library handles it should get "mkstemp.c" and 
> "mkstemp.h", rather than having it be in the top-level directory.
We already have epan/filesystem which *might* fit better (but didn't had 
a closer look if it's really the case).

I would like to keep things as smooth as possible for now, as I would 
think my changes might introduce some more work to be done.

We might think about mkstemp later (and fix it for now) ...

Regards, ULFL