Ethereal-dev: Re: SV: [Ethereal-dev] patch for packet-isakmp.c to fix decoding ikev2payload

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Shoichi Sakane <sakane@xxxxxxxx>
Date: Thu, 29 Sep 2005 14:54:40 +0900
Hi,

> Could you please change to use proto_tree_add_ipv4() and
> proto_tree_add_ipv6() instead?
> Some of the proto_tree_add_text could probably be changed to use
> proto_tree_add_irem instead.

> A patch generated with diff -u a also much easier to read.

I forgot the manner to make a patch, I am sorry.
Next time, I will do that and also read doc/README.developer earnestly.